dolphinscheduler
dolphinscheduler copied to clipboard
[Improvement][ui] improving to find current version identifier(#15815)
Purpose of the pull request
close #15815, https://github.com/apache/dolphinscheduler/issues/15875
Brief change log
The version identifier of dolphinscheduler cannot be found on the UI. Please add the current version identifier on the UI. 在WEB 的UI界面上 无法找到当前运行的 dolphinscheduler 版本信息,无法确定当前运行的版本。
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
at testQueryProductInfo() method of UiPluginControllerTest class
(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md
Is this PR want to solve https://github.com/apache/dolphinscheduler/issues/15875 ?
Is this PR want to solve #15875 ?
Is this PR want to solve #15875 ? Yes, I am currently addressing the issue you mentioned
Is this PR want to solve #15875 ? I am currently addressing the issue you mentioned, yes, and also addressing 15875
I can't find the code for the UI part. Where is it?
The front-end code has also been completed and will be submitted after the back-end is error free
The front-end code has also been completed and will be submitted after the back-end is error free
Features like this need to be committed at both the backend and frontend.
The front-end code has also been completed and will be submitted after the back-end is error free
Features like this need to be committed at both the backend and frontend.
Okay, then I will modify the interface return class and resubmit the front-end and back-end code
The front-end code has also been completed and will be submitted after the back-end is error free
Features like this need to be committed at both the backend and frontend.
+1
The front-end code has also been completed and will be submitted after the back-end is error free
Features like this need to be committed at both the backend and frontend.
+1 I have modified the backend code as required and submitted the frontend code at the same time. Here is a screenshot of the completed version
The front-end code has also been completed and will be submitted after the back-end is error free
Features like this need to be committed at both the backend and frontend.
I have modified the backend code as required and submitted the frontend code at the same time. Here is a screenshot of the completed version
Personally, I feel that there is no need to use a separate page to display the current version. You can put the version information at the top of this drop-down menu.
Personally, I feel that there is no need to use a separate page to display the current version. You can put the version information at the top of this drop-down menu.
Okay, I have removed the unused front-end references. According to my original plan, after completing the version function, document help, problem report submission, policy instructions, and service terms will also be placed on this page. If the version information is placed separately in the homepage column and other functions are added, it will appear crowded
Codecov Report
Attention: Patch coverage is 62.50000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 40.71%. Comparing base (
834c320
) to head (2fe4101
).
:exclamation: Current head 2fe4101 differs from pull request most recent head 8924bd8
Please upload reports for the commit 8924bd8 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
...cheduler/api/service/impl/UiPluginServiceImpl.java | 40.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## dev #15933 +/- ##
=========================================
Coverage 40.71% 40.71%
- Complexity 5246 5247 +1
=========================================
Files 1385 1385
Lines 46109 46117 +8
Branches 4923 4923
=========================================
+ Hits 18771 18775 +4
- Misses 25412 25415 +3
- Partials 1926 1927 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@SbloodyS PTAL
Some NIP, it's not a good idea to add a unknown version here, version is a must.
Thanks. In the scenario, unless the database version is empty, there will be no unknown
Please resolve conflicts.
oh, the reason for the conflict is that the enumeration class was not updated for a long time and has now been processed and resubmitted
Awesome work, congrats on your first merged pull request!