dolphinscheduler
dolphinscheduler copied to clipboard
[fix-15907] Fix get remote shell exit code is incorrect
Purpose of the pull request
fix https://github.com/apache/dolphinscheduler/issues/15907
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 39.86%. Comparing base (
ba5de75
) to head (397a221
).
:exclamation: Current head 397a221 differs from pull request most recent head 9879748. Consider uploading reports for the commit 9879748 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## dev #15911 +/- ##
============================================
- Coverage 39.86% 39.86% -0.01%
+ Complexity 5060 5059 -1
============================================
Files 1369 1369
Lines 45635 45635
Branches 4869 4869
============================================
- Hits 18193 18192 -1
Misses 25544 25544
- Partials 1898 1899 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
It seems a new bug has been introduced.
The .trim() in the original code is necessary, otherwise the case of xxx-0\n cannot be handled.