dolphinscheduler
dolphinscheduler copied to clipboard
Fix jar path is not correct in java task
Purpose of the pull request
close https://github.com/apache/dolphinscheduler/issues/15902
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 39.74%. Comparing base (
647cbae
) to head (f6366d5
).
:exclamation: Current head f6366d5 differs from pull request most recent head 9d95b18. Consider uploading reports for the commit 9d95b18 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## dev #15906 +/- ##
============================================
+ Coverage 39.66% 39.74% +0.07%
- Complexity 5016 5037 +21
============================================
Files 1353 1353
Lines 45637 45619 -18
Branches 4892 4891 -1
============================================
+ Hits 18100 18129 +29
+ Misses 25622 25575 -47
Partials 1915 1915
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Some humble suggestion, next time, can you add additional explanations for the modifications made after PR is approved when performing a force-push?
Some humble suggestion, next time, can you add additional explanations for the modifications made after PR is approved when performing a force-push?
Thanks for your suggestion, I will add message next time, I'm just worried that these won't be cleaned up in the merger.
Some humble suggestion, next time, can you add additional explanations for the modifications made after PR is approved when performing a force-push?
Thanks for your suggestion, I will add message next time, I'm just worried that these won't be cleaned up in the merger.
Yeah, I can get your point, keep one commit is cleaner. With additional message, review the PR again will be faster :D
Quality Gate failed
Failed conditions
D Maintainability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint