dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Fix-15828] fix expandListParameter

Open xxzuo opened this issue 10 months ago • 2 comments

Purpose of the pull request

  • fix #15828
  • Expand the list parameters when matching ${} instead of first replacing ${} with a ? and then processing the parameters based on the ?

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

xxzuo avatar Apr 18 '24 15:04 xxzuo

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 39.62%. Comparing base (e9d8591) to head (d32f5c8).

:exclamation: Current head d32f5c8 differs from pull request most recent head 3ce3730. Consider uploading reports for the commit 3ce3730 to get more accurate results

Files Patch % Lines
...dolphinscheduler/plugin/task/api/AbstractTask.java 0.00% 3 Missing :warning:
...olphinscheduler/plugin/task/api/TaskConstants.java 0.00% 3 Missing :warning:
...ache/dolphinscheduler/plugin/task/sql/SqlTask.java 0.00% 3 Missing :warning:
...cheduler/plugin/task/api/utils/ParameterUtils.java 87.50% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15878      +/-   ##
============================================
- Coverage     39.64%   39.62%   -0.02%     
+ Complexity     5023     5021       -2     
============================================
  Files          1349     1349              
  Lines         45593    45595       +2     
  Branches       4890     4888       -2     
============================================
- Hits          18074    18067       -7     
- Misses        25596    25605       +9     
  Partials       1923     1923              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 23 '24 01:04 codecov-commenter

Quality Gate Failed Quality Gate failed

Failed conditions
58.1% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 23 '24 01:04 sonarqubecloud[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
42.3% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 16 '24 12:05 sonarqubecloud[bot]