dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[DSIP-25][Remote Logging] Split remote logging configuration

Open pegasas opened this issue 1 year ago • 2 comments

Purpose of the pull request

resolve: https://github.com/apache/dolphinscheduler/issues/15774

Brief change log

image

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

pegasas avatar Apr 10 '24 23:04 pegasas

Codecov Report

Attention: Patch coverage is 68.18182% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 39.81%. Comparing base (fa6ea8b) to head (0a143a4).

:exclamation: Current head 0a143a4 differs from pull request most recent head 2dcdddf. Consider uploading reports for the commit 2dcdddf to get more accurate results

Files Patch % Lines
...scheduler/common/config/ImmutableYamlDelegate.java 61.53% 10 Missing :warning:
...mmon/config/ImmutablePriorityPropertyDelegate.java 81.25% 3 Missing :warning:
...duler/common/config/ImmutablePropertyDelegate.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15826      +/-   ##
============================================
- Coverage     39.89%   39.81%   -0.08%     
+ Complexity     5057     5038      -19     
============================================
  Files          1353     1354       +1     
  Lines         45621    45659      +38     
  Branches       4891     4894       +3     
============================================
- Hits          18199    18181      -18     
- Misses        25516    25572      +56     
  Partials       1906     1906              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 25 '24 11:04 codecov-commenter

Please retry analysis of this Pull-Request directly on SonarCloud

sonarqubecloud[bot] avatar May 06 '24 02:05 sonarqubecloud[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
16.1% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 06 '24 02:05 sonarqubecloud[bot]