dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[bug][ui] fix ui Failed to query list after editing file

Open bajiaolong opened this issue 11 months ago • 11 comments

fix: #15644

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

bajiaolong avatar Feb 28 '24 06:02 bajiaolong

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.86%. Comparing base (ace20f9) to head (794ffb1).

:exclamation: Current head 794ffb1 differs from pull request most recent head 21304bb. Consider uploading reports for the commit 21304bb to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15647   +/-   ##
=========================================
  Coverage     39.86%   39.86%           
- Complexity     5060     5064    +4     
=========================================
  Files          1369     1369           
  Lines         45635    45635           
  Branches       4869     4868    -1     
=========================================
  Hits          18193    18193           
  Misses        25544    25544           
  Partials       1898     1898           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 28 '24 08:02 codecov-commenter

@bajiaolong please check the CI error

Sorry, I don't know which one to solve. can you help me?

bajiaolong avatar Mar 18 '24 07:03 bajiaolong

@bajiaolong please check the CI error

Sorry, I don't know which one to solve. can you help me?

image @bajiaolong cc @songjianet @c3Vu @arlendp I am also not familiar with front-end, please help

rickchengx avatar Mar 18 '24 08:03 rickchengx

@bajiaolong please check the CI error

Sorry, I don't know which one to solve. can you help me?

image @bajiaolong cc @songjianet @c3Vu @arlendp I am also not familiar with front-end, please help

This CI build error seems to has nothing to do with this commit. It is the execution of eslint --fix in the CI process that caused the code formatting error.

arlendp avatar Mar 18 '24 09:03 arlendp

This will be fixed after this pr is merged. #15732 @bajiaolong

SbloodyS avatar Mar 18 '24 09:03 SbloodyS

This will be fixed after this pr is merged. #15732 @bajiaolong

RECD

bajiaolong avatar Mar 19 '24 01:03 bajiaolong

@bajiaolong it seems CI cannot pass image

rickchengx avatar Mar 28 '24 08:03 rickchengx

Please retry analysis of this Pull-Request directly on SonarCloud

sonarqubecloud[bot] avatar May 10 '24 08:05 sonarqubecloud[bot]

@rickchengx @ruanwenjun @EricGao888 PTAL.

SbloodyS avatar May 10 '24 08:05 SbloodyS

@rickchengx @ruanwenjun @EricGao888 PTAL.

I'm not familiar with front-end stuff. Would u plz take a look? @arlendp @c3Vu

EricGao888 avatar May 10 '24 08:05 EricGao888

Awesome work, congrats on your first merged pull request!

boring-cyborg[bot] avatar Jul 16 '24 09:07 boring-cyborg[bot]