dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Bug] [dolphinscheduler-ui] UI timed scheduler Improvement

Open cqutwangyu opened this issue 1 year ago • 3 comments

Purpose of the pull request

fix https://github.com/apache/dolphinscheduler/issues/15623

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

cqutwangyu avatar Feb 23 '24 11:02 cqutwangyu

@songjianet @Amy0104 please cc

cqutwangyu avatar Feb 23 '24 11:02 cqutwangyu

@cqutwangyu Thanks for your contribution, can you upload a page snapshot at the same time?

Gallardot avatar Feb 23 '24 13:02 Gallardot

@Gallardot ok,I recorded the video

this is error

https://github.com/apache/dolphinscheduler/assets/26395835/6e70c8ce-89aa-41eb-85f9-1296968d3996

this is fix

https://github.com/apache/dolphinscheduler/assets/26395835/daa2213e-33bf-4567-84cb-7b0bb80d03df

cqutwangyu avatar Feb 23 '24 14:02 cqutwangyu

image

songjianet avatar Feb 26 '24 00:02 songjianet

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.61%. Comparing base (04a6b0d) to head (7615e4e).

:exclamation: Current head 7615e4e differs from pull request most recent head 6bc8ff2. Consider uploading reports for the commit 6bc8ff2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15624      +/-   ##
============================================
- Coverage     38.63%   38.61%   -0.03%     
+ Complexity     4795     4791       -4     
============================================
  Files          1316     1316              
  Lines         44969    44969              
  Branches       4817     4817              
============================================
- Hits          17373    17363      -10     
- Misses        25713    25724      +11     
+ Partials       1883     1882       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 26 '24 00:02 codecov-commenter

Hello, I checked the error message and I found that the error message is not related to the content I modified. I then executed the pnpm run build:prod command on my computer, and the package was successful.

---Original--- From: @.> Date: Mon, Feb 26, 2024 08:38 AM To: @.>; Cc: @.@.>; Subject: Re: [apache/dolphinscheduler] [Bug] [dolphinscheduler-ui] UI timed scheduler Improvement (PR #15624)

image.png (view on web)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

cqutwangyu avatar Feb 26 '24 01:02 cqutwangyu

cc @c3Vu @arlendp

rickchengx avatar Feb 26 '24 08:02 rickchengx

I have tested this PR in my dev cluster, it works well and the issue has been fixed. Thanks @cqutwangyu .

What should be the next step to proceed with this PR?

@songjianet @cqutwangyu @rickchengx

Gallardot avatar Feb 27 '24 12:02 Gallardot

I have tested this PR in my dev cluster, it works well and the issue has been fixed. Thanks @cqutwangyu .

What should be the next step to proceed with this PR?

@songjianet @cqutwangyu @rickchengx

@cqutwangyu please fix the failed CI

rickchengx avatar Feb 29 '24 08:02 rickchengx

I have tested this PR in my dev cluster, it works well and the issue has been fixed. Thanks @cqutwangyu . What should be the next step to proceed with this PR? @songjianet @cqutwangyu @rickchengx

@cqutwangyu please fix the failed CI

OK, FIXED

cqutwangyu avatar Mar 01 '24 04:03 cqutwangyu

cc @c3Vu @arlendp

i test the pr in local dev environment, it works as expected and did solve https://github.com/apache/dolphinscheduler/issues/15623 @rickchengx

arlendp avatar Mar 04 '24 05:03 arlendp