dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

Data source plugin support xugu database

Open mrliufox opened this issue 1 year ago • 18 comments

Purpose of the pull request

Data source plugin support xugu database

Brief change log

Data source plugin support xugu database

Verify this pull request

This change added tests and can be verified as follows:

  • Added XuguDataSourceChannelFactoryTest to verify the change.
  • Added XuguDataSourceChannelTest to verify the change.

mrliufox avatar Feb 20 '24 07:02 mrliufox

❌ (Please check if there are PRs that already have a ready-to-merge label and can be merged, if exists please merge them first.)

But I have no merging branches

mrliufox avatar Feb 20 '24 07:02 mrliufox

❌ (Please check if there are PRs that already have a ready-to-merge label and can be merged, if exists please merge them first.)

I have no merging branches

mrliufox avatar Feb 20 '24 08:02 mrliufox

❌ (Please check if there are PRs that already have a ready-to-merge label and can be merged, if exists please merge them first.)

I have no merging branches

mrliufox avatar Feb 20 '24 09:02 mrliufox

Codecov Report

Attention: Patch coverage is 65.67164% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 39.56%. Comparing base (27d0563) to head (ed7ca12).

:exclamation: Current head ed7ca12 differs from pull request most recent head 2f089f8. Consider uploading reports for the commit 2f089f8 to get more accurate results

Files Patch % Lines
...datasource/xugu/param/XuguDataSourceProcessor.java 72.00% 12 Missing and 2 partials :warning:
...gin/datasource/xugu/XuguAdHocDataSourceClient.java 0.00% 2 Missing :warning:
.../plugin/datasource/xugu/XuguDataSourceChannel.java 33.33% 2 Missing :warning:
...in/datasource/xugu/XuguPooledDataSourceClient.java 0.00% 2 Missing :warning:
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% 2 Missing :warning:
.../datasource/xugu/param/XuguDataSourceParamDTO.java 66.66% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15601      +/-   ##
============================================
- Coverage     39.59%   39.56%   -0.03%     
+ Complexity     5010     5007       -3     
============================================
  Files          1347     1354       +7     
  Lines         45646    45712      +66     
  Branches       4892     4894       +2     
============================================
+ Hits          18073    18087      +14     
- Misses        25648    25699      +51     
- Partials       1925     1926       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 21 '24 00:02 codecov-commenter

_Error: One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0': _

Please guide me on how to deal with this problem, thank you very much.

mrliufox avatar Feb 21 '24 02:02 mrliufox

what should i do next?

mrliufox avatar Feb 21 '24 05:02 mrliufox

❌ (Please check if there are PRs that already have a ready-to-merge label and can be merged, if exists please merge them first.)

I don't have a branch merging.

mrliufox avatar Feb 21 '24 07:02 mrliufox

I haven't found any mail in dev mail list. Please send an email to [email protected] and explain the significance of supporting xugu database in apache dolphinscheduler. @mrliufox

SbloodyS avatar Feb 23 '24 01:02 SbloodyS

I haven't found any mail in dev mail list. Please send an email to [email protected] and explain the significance of supporting xugu database in apache dolphinscheduler. @mrliufox

I sent it on February 19, 2024 and it shows that the delivery was successful. Please confirm whether it was intercepted in the trash can. Snipaste_2024-02-23_14-18-39

mrliufox avatar Feb 23 '24 06:02 mrliufox

Maybe you did not subscribe dev mail list. You should subscribe it first. @mrliufox

SbloodyS avatar Feb 23 '24 06:02 SbloodyS

Maybe you did not subscribe dev mail list. You should subscribe it first. @mrliufox

how to subscribe dev mail list? Please guide, thank you very much.

mrliufox avatar Feb 23 '24 06:02 mrliufox

You can take a look at https://github.com/apache/dolphinscheduler/issues/8847. @mrliufox

SbloodyS avatar Feb 23 '24 07:02 SbloodyS

You can take a look at #8847. @mrliufox

Thank you very much, I have subscribed to the dev email list and sented an email to [email protected] to explain the importance of dolphinscheduler for xugu database support

mrliufox avatar Feb 23 '24 07:02 mrliufox

what should i do next?

mrliufox avatar Feb 26 '24 01:02 mrliufox

help please ! what should i do next

mrliufox avatar Mar 04 '24 02:03 mrliufox

what should i do next ?

mrliufox avatar Mar 18 '24 02:03 mrliufox

Currently, there are no maintainer is willing to accept the maintenance of this data source. So this PR will be temporarily put on hold until a maintainer is willing to continue maintaining it. @mrliufox

SbloodyS avatar Mar 18 '24 02:03 SbloodyS

Please retry analysis of this Pull-Request directly on SonarCloud

sonarqubecloud[bot] avatar Apr 16 '24 04:04 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Aug 15 '24 00:08 github-actions[bot]