dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Bug] [UI] Projects] Custom parameters do not trigger validation when the added number during task created is greater than 2

Open JeremyXin opened this issue 1 year ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

What happened

When i try to create a Task Definition as Batch Task or create a Workflow Definition as SQL, i found that the custom parameter module could not trigger the validator in some situation. The condition as below

What you expected to happen

In normal case, the custom parameter module would verify that whether duplicate values exist in prop property values. If so, it would prompt: prop is repeat. When the creation task is performed, the custom parameter form appears fine, as below screenshot, but when the task is modified, some unexpected problems occur. situation 0

Situation 1: If the number of custom parameters added during task creation is greater than two, the validator verification would not be performed when the custom parameters are added. The screenshot is as follows: situation1

and the save operation could be performed.

Also, When adding the custom parameter, if the prop property is the same as the first prop value, it would prompt the message: prop is repeat. situation2

Situation 2: If the number of custom parameters added during task creation is less than two, the validator verification would be performed fine. the situation is as follows: situation 3

How to reproduce

According to the above description and screenshots can be reproduced

Anything else

No response

Version

3.1.x

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

JeremyXin avatar Jan 04 '24 11:01 JeremyXin