dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[feature#14818] alert-spi support FeiShuPersonalWork

Open xjlgod opened this issue 1 year ago • 8 comments

Purpose of the pull request

to add dinding talk personal work notification close https://github.com/apache/dolphinscheduler/issues/14818

Implementation Mechanism: enterprise-app enable-bot-ability send-meeage

Brief change log

a new moudle dolphinscheduler-alert-feishu-personalwork be added

Verify this pull request

image

69864f80d46b3ea97f6a7188f6f9410

xjlgod avatar Oct 03 '23 07:10 xjlgod

Since we already have dolphinscheduler-alert-feishu module. I think it's better add this in it.

Do you mean to put the code in dolphinscheduler-alert-feishu module, or this feishu personal work plugin should also be integrated into feishu plugin. If it were the second one, I think it would make the feishu plugin look bulky and require many parameters to be filled in.

xjlgod avatar Oct 08 '23 11:10 xjlgod

Yes. Please putting the code in dolphinscheduler-alert-feishu module. @xjlgod

SbloodyS avatar Oct 10 '23 02:10 SbloodyS

Yes. Please putting the code in dolphinscheduler-alert-feishu module. @xjlgod

please check it

xjlgod avatar Oct 10 '23 12:10 xjlgod

Codecov Report

Merging #14982 (bcc18a9) into dev (d983e36) will increase coverage by 0.03%. Report is 5 commits behind head on dev. The diff coverage is 49.26%.

:exclamation: Current head bcc18a9 differs from pull request most recent head 989e4d9. Consider uploading reports for the commit 989e4d9 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14982      +/-   ##
============================================
+ Coverage     38.90%   38.94%   +0.03%     
- Complexity     4611     4627      +16     
============================================
  Files          1236     1241       +5     
  Lines         43449    43654     +205     
  Branches       4809     4823      +14     
============================================
+ Hits          16905    16999      +94     
- Misses        24670    24778     +108     
- Partials       1874     1877       +3     
Files Coverage Δ
...nalwork/FeiShuPersonalWorkAlertChannelFactory.java 97.29% <97.29%> (ø)
...personalwork/FeiShuPersonalWorkParamConstants.java 0.00% <0.00%> (ø)
...u/personalwork/FeiShuPersonalWorkAlertChannel.java 16.66% <16.66%> (ø)
...hu/personalwork/FeiShuPersonalWorkAccessToken.java 0.00% <0.00%> (ø)
.../feishu/personalwork/FeiShuPersonalWorkSender.java 42.66% <42.66%> (ø)

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 13 '23 03:10 codecov-commenter

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

33.4% 33.4% Coverage
1.3% 1.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Oct 16 '23 01:10 sonarqubecloud[bot]

These two pictures show how to use group notifications and personal work notifications @SbloodyS 9e69b4d3ccd00de5a0537e6e9c8696f 524f227d3e4a61d41a4c36b4c12bc19

xjlgod avatar Oct 24 '23 12:10 xjlgod

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Feb 22 '24 00:02 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Jun 30 '24 00:06 github-actions[bot]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

github-actions[bot] avatar Jul 07 '24 00:07 github-actions[bot]