dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Fix] [Bug] Fix bugs such as missing status and workflow when creating and modifying task definitions

Open jinyanhui2008 opened this issue 3 years ago • 3 comments

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

jinyanhui2008 avatar Sep 22 '22 06:09 jinyanhui2008

@jinyanhui2008 please add some description of this pr.

caishunfeng avatar Sep 22 '22 06:09 caishunfeng

Codecov Report

:exclamation: No coverage uploaded for pull request base (3.0.1-release@b3c27ef). Click here to learn what that means. The diff coverage is n/a.

@@               Coverage Diff                @@
##             3.0.1-release   #12100   +/-   ##
================================================
  Coverage                 ?   39.86%           
  Complexity               ?     4581           
================================================
  Files                    ?      888           
  Lines                    ?    35166           
  Branches                 ?     3873           
================================================
  Hits                     ?    14018           
  Misses                   ?    19788           
  Partials                 ?     1360           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 22 '22 07:09 codecov-commenter

Repair task definition function:

  1. Modification of task definition may lead to loss of workflow definition and status

  2. Missing predecessors when modifying task definitions

  3. Creating and modifying task definitions will lose workflow definitions of other task definitions

jinyanhui2008 avatar Sep 23 '22 00:09 jinyanhui2008