dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Fix][Worker] alert email in sql task in K8S

Open BruceMaa opened this issue 3 years ago • 2 comments

worker.alert-listen-host has not get ALERT_LISTEN_HOST environment variable in worker containers env

Purpose of the pull request

This pull request fix #12088

Brief change log

This pull request eidt worker application.yaml

work: alert-listen-host: ${ALERT_LISTEN_HOST:localhost}

Verify this pull request

This pull request is code cleanup without any test coverage.

BruceMaa avatar Sep 21 '22 09:09 BruceMaa

Codecov Report

Merging #12090 (052352e) into dev (ac84504) will increase coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev   #12090   +/-   ##
=========================================
  Coverage     38.93%   38.93%           
- Complexity     4177     4178    +1     
=========================================
  Files          1040     1040           
  Lines         38797    38797           
  Branches       4460     4460           
=========================================
+ Hits          15105    15107    +2     
+ Misses        21923    21922    -1     
+ Partials       1769     1768    -1     
Impacted Files Coverage Δ
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.85% <0.00%> (+0.71%) :arrow_up:
...r/plugin/task/sqoop/parameter/SqoopParameters.java 56.41% <0.00%> (+1.28%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 21 '22 09:09 codecov-commenter

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 23 '22 01:09 sonarqubecloud[bot]

rerun the fail CI

caishunfeng avatar Sep 23 '22 06:09 caishunfeng

I can confirm this pr can fix the issue. can reviewers try to review it again?

simsicon avatar Oct 08 '22 07:10 simsicon

Seems the CI Mergeable: milestone-label-check block, but how to check the detail or rerun it? @zhongjiajie

caishunfeng avatar Oct 11 '22 06:10 caishunfeng

@BruceMaa can you rebase on dev and then push to restart the CI?

zhongjiajie avatar Oct 11 '22 08:10 zhongjiajie

sorry, I did it wrong, now open another PR. #12369

@zhongjiajie @caishunfeng @fuchanghai

BruceMaa avatar Oct 14 '22 02:10 BruceMaa