dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement][Master] fix issue#12001

Open DarkAssassinator opened this issue 3 years ago • 2 comments

Purpose of the pull request

fix #12001

Brief change log

Just add a validator before task instance was put to dispatch queue. Why need this change? Because check the worker group before add to dispatch queue can avoid invalid infinite loops in TaskPriorityQueueConsumer

Verify this pull request

DarkAssassinator avatar Sep 19 '22 13:09 DarkAssassinator

Codecov Report

Merging #12051 (277dd7f) into dev (8cddb10) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev   #12051   +/-   ##
=========================================
  Coverage     38.65%   38.66%           
- Complexity     4005     4006    +1     
=========================================
  Files          1002     1002           
  Lines         37213    37219    +6     
  Branches       4249     4250    +1     
=========================================
+ Hits          14386    14390    +4     
- Misses        21195    21196    +1     
- Partials       1632     1633    +1     
Impacted Files Coverage Δ
...server/master/runner/task/CommonTaskProcessor.java 17.24% <0.00%> (-1.28%) :arrow_down:
...eduler/server/worker/task/WorkerHeartBeatTask.java 77.55% <0.00%> (+8.16%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 19 '22 14:09 codecov-commenter

Hi @DarkAssassinator please use the correct title, thanks~

caishunfeng avatar Sep 23 '22 01:09 caishunfeng

Hi @DarkAssassinator please use the correct title, thanks~

ohh. so sorry. done

DarkAssassinator avatar Sep 23 '22 01:09 DarkAssassinator

Misuse coverage in conflict resolution, close it and re-open

DarkAssassinator avatar Sep 25 '22 15:09 DarkAssassinator