dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Feature][API] New restful API for workflow and schedule

Open zhongjiajie opened this issue 3 years ago • 6 comments

CURD for workflow and schedule, different with exists API, this new restful api only operate single resource in each request, and return the latest. For example, previous workflow should also need to post tasks definition and tasks relation definition, but this patch will allow you to create workflow without task relate information

zhongjiajie avatar Sep 13 '22 10:09 zhongjiajie

This PR is not equal to refactored exists API as #10257 do, we also separate existingprocess definition and schedule into single resources CRUD(previous process definition also will submit tasks and task relation). And we make it more Restful

zhongjiajie avatar Sep 15 '22 01:09 zhongjiajie

Codecov Report

Merging #11912 (9e88f87) into dev (6eb1eb7) will increase coverage by 0.37%. The diff coverage is 67.62%.

@@             Coverage Diff              @@
##                dev   #11912      +/-   ##
============================================
+ Coverage     38.69%   39.07%   +0.37%     
- Complexity     4010     4082      +72     
============================================
  Files          1001     1010       +9     
  Lines         37422    37696     +274     
  Branches       4262     4326      +64     
============================================
+ Hits          14480    14728     +248     
+ Misses        21295    21281      -14     
- Partials       1647     1687      +40     
Impacted Files Coverage Δ
...eduler/api/dto/schedule/ScheduleFilterRequest.java 0.00% <0.00%> (ø)
...scheduler/api/controller/ScheduleV2Controller.java 9.09% <9.09%> (ø)
...eduler/api/dto/workflow/WorkflowFilterRequest.java 33.33% <33.33%> (ø)
...cheduler/api/service/impl/ExecutorServiceImpl.java 43.73% <37.50%> (+0.39%) :arrow_up:
...eduler/api/dto/schedule/ScheduleUpdateRequest.java 41.66% <41.66%> (ø)
...er/api/controller/ProcessDefinitionController.java 51.04% <50.00%> (+1.53%) :arrow_up:
...eduler/api/dto/workflow/WorkflowUpdateRequest.java 50.00% <50.00%> (ø)
...api/service/impl/ProcessDefinitionServiceImpl.java 33.81% <61.90%> (+2.43%) :arrow_up:
...heduler/api/service/impl/SchedulerServiceImpl.java 26.77% <71.57%> (+17.89%) :arrow_up:
...scheduler/api/controller/WorkflowV2Controller.java 85.71% <85.71%> (ø)
... and 14 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 16 '22 12:09 codecov-commenter

fix conflict from adding log in #11782

zhongjiajie avatar Sep 17 '22 12:09 zhongjiajie

PTAL if you have time @caishunfeng @SbloodyS

zhongjiajie avatar Sep 19 '22 02:09 zhongjiajie

we still have discuss in https://github.com/apache/dolphinscheduler/pull/11912#discussion_r973823553 and https://github.com/apache/dolphinscheduler/pull/11912#discussion_r973825097

zhongjiajie avatar Sep 21 '22 10:09 zhongjiajie

Thanks @zhongjiajie

caishunfeng avatar Sep 23 '22 14:09 caishunfeng