dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Feature][TASK-PLUGIN] AWS Database Migration Service (DMS)

Open jieguangzhou opened this issue 3 years ago • 2 comments

Purpose of the pull request

close: #11672

Brief change log

  • [x] Create and start DMS task by interface
  • [x] Create and start DMS task by json data
  • [x] Restart DMS task by interface
  • [x] Restart DMS task by json data

Create and start DMS task by interface

image

Create and start DMS task by json data

image

Restart DMS task by interface

image

Restart DMS task by json data

image

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

jieguangzhou avatar Sep 09 '22 01:09 jieguangzhou

Codecov Report

Merging #11868 (22e3afc) into dev (d526dd8) will increase coverage by 0.10%. The diff coverage is 55.51%.

@@             Coverage Diff              @@
##                dev   #11868      +/-   ##
============================================
+ Coverage     39.40%   39.51%   +0.10%     
- Complexity     4128     4165      +37     
============================================
  Files          1010     1016       +6     
  Lines         37817    38069     +252     
  Branches       4345     4379      +34     
============================================
+ Hits          14903    15042     +139     
- Misses        21188    21287      +99     
- Partials       1726     1740      +14     
Impacted Files Coverage Δ
...olphinscheduler/plugin/task/dms/DmsParameters.java 0.00% <0.00%> (ø)
...lphinscheduler/plugin/task/dms/DmsTaskChannel.java 0.00% <0.00%> (ø)
...heduler/plugin/task/dms/DmsTaskChannelFactory.java 0.00% <0.00%> (ø)
...ache/dolphinscheduler/plugin/task/dms/DmsTask.java 52.74% <52.74%> (ø)
...ache/dolphinscheduler/plugin/task/dms/DmsHook.java 63.30% <63.30%> (ø)
...nscheduler/plugin/alert/http/HttpAlertChannel.java 66.66% <0.00%> (-33.34%) :arrow_down:
...dolphinscheduler/plugin/alert/http/HttpSender.java 47.69% <0.00%> (-6.28%) :arrow_down:
...apache/dolphinscheduler/service/log/LogClient.java 41.41% <0.00%> (-2.16%) :arrow_down:
...he/dolphinscheduler/server/utils/ProcessUtils.java 28.57% <0.00%> (-2.12%) :arrow_down:
...olphinscheduler/plugin/task/mlflow/MlflowTask.java 57.75% <0.00%> (-1.73%) :arrow_down:
... and 6 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 09 '22 15:09 codecov-commenter

Hi @jieguangzhou is this pr ready for review?

caishunfeng avatar Sep 23 '22 13:09 caishunfeng

@caishunfeng @EricGao888 PTAL, thanks.

jieguangzhou avatar Sep 28 '22 06:09 jieguangzhou

PTAL

Done, PTAL, thanks

jieguangzhou avatar Sep 28 '22 07:09 jieguangzhou

@Amy0104 PTAL, thanks

jieguangzhou avatar Sep 29 '22 07:09 jieguangzhou

Thanks all

jieguangzhou avatar Sep 30 '22 02:09 jieguangzhou