dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Bug] [Common] update IPv4 Pattern

Open DarkAssassinator opened this issue 2 years ago • 3 comments

Purpose of the pull request

fix #11758

Brief change log

just update IPv4 Pattern

Verify this pull request

add some UT

DarkAssassinator avatar Sep 03 '22 05:09 DarkAssassinator

Codecov Report

Merging #11762 (4ac9855) into dev (d0f5e7e) will decrease coverage by 1.07%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev   #11762      +/-   ##
============================================
- Coverage     39.73%   38.65%   -1.08%     
+ Complexity     4709     4005     -704     
============================================
  Files          1008     1002       -6     
  Lines         37878    37212     -666     
  Branches       4238     4249      +11     
============================================
- Hits          15049    14385     -664     
+ Misses        21218    21195      -23     
- Partials       1611     1632      +21     
Impacted Files Coverage Δ
...apache/dolphinscheduler/common/utils/NetUtils.java 50.00% <100.00%> (-0.36%) :arrow_down:
...olphinscheduler/plugin/task/dvc/DvcParameters.java 0.00% <0.00%> (-100.00%) :arrow_down:
...lphinscheduler/dao/entity/ProcessTaskRelation.java 0.00% <0.00%> (-62.50%) :arrow_down:
...ache/dolphinscheduler/dao/entity/K8sNamespace.java 18.18% <0.00%> (-57.23%) :arrow_down:
...a/org/apache/dolphinscheduler/dao/entity/User.java 18.18% <0.00%> (-55.96%) :arrow_down:
...apache/dolphinscheduler/dao/entity/DataSource.java 18.18% <0.00%> (-54.99%) :arrow_down:
...g/apache/dolphinscheduler/dao/entity/Resource.java 0.00% <0.00%> (-48.24%) :arrow_down:
...he/dolphinscheduler/dao/entity/TaskGroupQueue.java 20.00% <0.00%> (-46.04%) :arrow_down:
...apache/dolphinscheduler/dao/entity/AlertGroup.java 4.00% <0.00%> (-44.94%) :arrow_down:
...olphinscheduler/dao/entity/ProcessInstanceMap.java 0.00% <0.00%> (-41.94%) :arrow_down:
... and 216 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 03 '22 06:09 codecov-commenter

IPAddressUtil.isIPv4LiteralAddress do not support JDK8+, need to replace with InetAddressUtils.isIPv4Address.

DarkAssassinator avatar Sep 19 '22 14:09 DarkAssassinator

Thanks for your patch, this will be released at 3.0.1+ and 3.1.0+.

ruanwenjun avatar Sep 26 '22 01:09 ruanwenjun