dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[ fix: #11590 ][upgrade] Fix the bugs when I upgrade ds from v1.3.9 to v3.0.0 ,such as file cannot be found or column not found etc

Open wangfann opened this issue 2 years ago • 1 comments

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

wangfann avatar Aug 23 '22 11:08 wangfann

to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.

SbloodyS avatar Aug 24 '22 01:08 SbloodyS

@caishunfeng @zhuangchong I also have the problem of upgrading. When will this PR be merged ? I think this is very useful.

fengjian1129 avatar Sep 23 '22 10:09 fengjian1129

can you also check whether Postgres exists this issue or not? @wangfann

I just submitted the code,please review it.

wangfann avatar Oct 10 '22 09:10 wangfann

can you also check whether Postgres exists this issue or not? @wangfann

@zhongjiajie Thanks

wangfann avatar Oct 10 '22 09:10 wangfann

LGTM, it is database schema change, I would like to ask another opinion @SbloodyS @caishunfeng @ruanwenjun

zhongjiajie avatar Oct 10 '22 12:10 zhongjiajie

Codecov Report

Merging #11619 (ce376a4) into dev (db925f3) will decrease coverage by 1.27%. The diff coverage is 14.28%.

:exclamation: Current head ce376a4 differs from pull request most recent head 4073008. Consider uploading reports for the commit 4073008 to get more accurate results

@@             Coverage Diff              @@
##                dev   #11619      +/-   ##
============================================
- Coverage     39.81%   38.53%   -1.28%     
+ Complexity     4700     4073     -627     
============================================
  Files           992     1023      +31     
  Lines         37732    38234     +502     
  Branches       4203     4377     +174     
============================================
- Hits          15022    14733     -289     
- Misses        21140    21781     +641     
- Partials       1570     1720     +150     
Impacted Files Coverage Δ
...hinscheduler/plugin/alert/script/ScriptSender.java 53.33% <ø> (-7.28%) :arrow_down:
...che/dolphinscheduler/alert/AlertPluginManager.java 100.00% <ø> (+6.25%) :arrow_up:
...dolphinscheduler/plugin/alert/http/HttpSender.java 47.69% <14.28%> (-6.28%) :arrow_down:
.../apache/dolphinscheduler/rpc/client/RpcClient.java 0.00% <0.00%> (-100.00%) :arrow_down:
...che/dolphinscheduler/rpc/protocol/RpcProtocol.java 0.00% <0.00%> (-100.00%) :arrow_down:
...e/dolphinscheduler/rpc/client/RpcRequestCache.java 0.00% <0.00%> (-100.00%) :arrow_down:
...e/dolphinscheduler/rpc/protocol/MessageHeader.java 0.00% <0.00%> (-100.00%) :arrow_down:
...dolphinscheduler/rpc/common/ThreadPoolManager.java 0.00% <0.00%> (-100.00%) :arrow_down:
...dolphinscheduler/rpc/serializer/RpcSerializer.java 0.00% <0.00%> (-100.00%) :arrow_down:
...lphinscheduler/rpc/common/AbstractRpcCallBack.java 0.00% <0.00%> (-100.00%) :arrow_down:
... and 370 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 10 '22 12:10 codecov-commenter

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 10 '22 12:10 sonarqubecloud[bot]