dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[FIX][BUG] issues 11499 dag is 0 when update task definition

Open rusonding opened this issue 2 years ago • 2 comments

Purpose of the pull request

Brief change log

close: #11499

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

rusonding avatar Aug 16 '22 14:08 rusonding

Codecov Report

Merging #11512 (f7a9879) into dev (2a7e0be) will decrease coverage by 0.01%. The diff coverage is 36.76%.

:exclamation: Current head f7a9879 differs from pull request most recent head e8e09b4. Consider uploading reports for the commit e8e09b4 to get more accurate results

@@             Coverage Diff              @@
##                dev   #11512      +/-   ##
============================================
- Coverage     39.36%   39.35%   -0.02%     
+ Complexity     4630     4625       -5     
============================================
  Files           987      987              
  Lines         37566    37554      -12     
  Branches       4184     4176       -8     
============================================
- Hits          14789    14779      -10     
+ Misses        21226    21221       -5     
- Partials       1551     1554       +3     
Impacted Files Coverage Δ
...api/service/impl/ProcessDefinitionServiceImpl.java 32.27% <ø> (ø)
...er/api/service/impl/TaskDefinitionServiceImpl.java 23.85% <0.00%> (-0.06%) :arrow_down:
.../server/master/runner/StateWheelExecuteThread.java 0.40% <ø> (ø)
...nscheduler/service/process/ProcessServiceImpl.java 31.89% <0.00%> (+0.02%) :arrow_up:
...lphinscheduler/plugin/task/api/utils/K8sUtils.java 3.84% <0.00%> (ø)
...uler/plugin/task/api/k8s/impl/K8sTaskExecutor.java 35.00% <54.54%> (-1.54%) :arrow_down:
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) :arrow_down:
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.00% <0.00%> (-2.78%) :arrow_down:
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) :arrow_down:
... and 15 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 16 '22 17:08 codecov-commenter