dolphinscheduler
dolphinscheduler copied to clipboard
[Improvement][Master] Events to improve
Search before asking
- [X] I had searched in the issues and found no similar feature requirement.
Description
I think we should check to see if there are identical events that are unique in the queue before adding events. In some cases, repeating a completed event may raise an exception
WorkflowExecuteRunnable.java
In addition, I think we should use poll() instead of peek() for fetch events, and add exception events to the end of the queue if they need to be processed repeatedly, otherwise they will always block processing of other events in the queue
WorkflowExecuteRunnable.java

Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
- In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
- If you haven't received a reply for a long time, you can join our slack and send your question to channel
#troubleshooting
Can you provide the steps to reproduce this issue? @luoxiqiang
Could you please provide the exception and event detail?
The StateWheelExecuteThread::checkTask4State method pushes events through the event queue and continues to push events when the same event has not been processed. For example, TaskStateEvent, The following exception is thrown if the task has completed but multiple identical TaskStateEvent events have not yet been handled
Earlier, here is the exception thrown StateEventHandleException, thus blocking the queue event handling, but now modified into StateEventHandleError discarded directly after the incident, although exceptions will be thrown also, but not influence the results, the optimization Suggestions can be ignored
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.