dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Feature-10182][task-datax]

Open lugela opened this issue 3 years ago • 5 comments

In the process of realizing datax synchronization, use custom json for better connection to enable kerberos-authenticated clusters, such as using plug-ins such as hdfs and hbase

Purpose of the pull request

Brief change log

In the process of datax synchronization, use custom json to enable kerberos-authenticated cluster for better connection. For example, if you use plug-ins such as hdfs and hbase us to use related keytab files or xml files, you can use the resource center module

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

lugela avatar Aug 10 '22 05:08 lugela

Codecov Report

Merging #11387 (ec97df8) into dev (82e9c40) will increase coverage by 0.00%. The diff coverage is 60.00%.

@@            Coverage Diff            @@
##                dev   #11387   +/-   ##
=========================================
  Coverage     39.93%   39.93%           
- Complexity     4599     4601    +2     
=========================================
  Files           967      967           
  Lines         36643    36647    +4     
  Branches       4091     4090    -1     
=========================================
+ Hits          14634    14636    +2     
- Misses        20499    20500    +1     
- Partials       1510     1511    +1     
Impacted Files Coverage Δ
...inscheduler/plugin/task/datax/DataxParameters.java 36.48% <60.00%> (+2.20%) :arrow_up:
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Aug 10 '22 05:08 codecov-commenter

hi, please tell me if ee2 failed, but after reading the log, I found that it has nothing to do with the change. What should I do here?

lugela avatar Aug 10 '22 08:08 lugela

hi, please tell me if ee2 failed, but after reading the log, I found that it has nothing to do with the change. What should I do here?

You could rebase the code or use git commit --amend and push again to force the CI to restart.

EricGao888 avatar Aug 10 '22 08:08 EricGao888

hi, please tell me if e2e failed, but after reading the log, I found that it has nothing to do with the change. What should I do here?

You could rebase the code or use git commit --amend and push again to force the CI to restart.

I expressed a problem, what I mean is that the e2e verification failed, and after reading the reason for the failure, I found that it is not related to the code I submitted

lugela avatar Aug 10 '22 08:08 lugela

hello, This pr corresponds to 'https://github.com/apache/dolphinscheduler/issues/10182' Can you help me check what else I should do?

lugela avatar Aug 15 '22 13:08 lugela