dolphinscheduler
dolphinscheduler copied to clipboard
[Improvement] Avoid using search in for and start using testSaveTaskD…
…efine()
Purpose of the pull request
Avoid using search in for and start using testSaveTaskDefine()
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md
Codecov Report
Merging #11383 (1e88ee5) into dev (8ad6e10) will decrease coverage by
0.67%. The diff coverage is68.75%.
@@ Coverage Diff @@
## dev #11383 +/- ##
============================================
- Coverage 40.25% 39.57% -0.68%
+ Complexity 4842 4623 -219
============================================
Files 974 980 +6
Lines 37323 37204 -119
Branches 4142 4159 +17
============================================
- Hits 15023 14725 -298
- Misses 20754 20947 +193
+ Partials 1546 1532 -14
| Impacted Files | Coverage Δ | |
|---|---|---|
| .../dolphinscheduler/common/utils/ParameterUtils.java | 58.53% <ø> (ø) |
|
| ...nscheduler/service/process/ProcessServiceImpl.java | 31.90% <68.75%> (+3.10%) |
:arrow_up: |
| ...e/dolphinscheduler/dao/entity/ProcessInstance.java | 0.00% <0.00%> (-65.57%) |
:arrow_down: |
| ...uler/api/service/impl/TaskInstanceServiceImpl.java | 58.41% <0.00%> (-30.48%) |
:arrow_down: |
| ...ache/dolphinscheduler/dao/entity/TaskInstance.java | 40.90% <0.00%> (-23.63%) |
:arrow_down: |
| ...heduler/api/controller/TaskInstanceController.java | 45.45% <0.00%> (-10.11%) |
:arrow_down: |
| ...hinscheduler/plugin/task/flink/FlinkArgsUtils.java | 63.41% <0.00%> (-5.62%) |
:arrow_down: |
| ...er/master/dispatch/host/assign/RandomSelector.java | 77.77% <0.00%> (-5.56%) |
:arrow_down: |
| .../org/apache/dolphinscheduler/common/Constants.java | 78.26% <0.00%> (-5.08%) |
:arrow_down: |
| ...inscheduler/server/master/metrics/TaskMetrics.java | 77.14% <0.00%> (-4.68%) |
:arrow_down: |
| ... and 118 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more







