[Feature] Add params check in createUser Function

[lyleshaw]

Purpose of the pull request

close #11277

• Add params check in createUser Function

Brief change log

• Add params check in createUser Function

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

[lyleshaw]

PTAL @zhongjiajie

[codecov-commenter]

Codecov Report

Merging #11255 (d8b6a51) into dev (f8b9aad) will decrease coverage by 0.00%. The diff coverage is 55.31%.

@@             Coverage Diff              @@
##                dev   #11255      +/-   ##
============================================
- Coverage     39.59%   39.58%   -0.01%     
- Complexity     4689     4696       +7     
============================================
  Files          1014     1014              
  Lines         37918    37910       -8     
  Branches       4238     4235       -3     
============================================
- Hits          15013    15007       -6     
- Misses        21297    21301       +4     
+ Partials       1608     1602       -6     

Impacted Files	Coverage Δ
...a/org/apache/dolphinscheduler/dao/entity/User.java	63.76% <16.66%> (-10.37%)	:arrow_down:
...inscheduler/api/service/impl/UsersServiceImpl.java	74.04% <68.57%> (+1.75%)	:arrow_up:
...inscheduler/server/log/LoggerRequestProcessor.java	17.30% <0.00%> (-0.17%)	:arrow_down:
...ver/master/runner/task/ConditionTaskProcessor.java	4.76% <0.00%> (-0.06%)	:arrow_down:
.../server/master/runner/WorkflowExecuteRunnable.java	7.97% <0.00%> (-0.03%)	:arrow_down:
...server/master/runner/task/SwitchTaskProcessor.java	2.52% <0.00%> (-0.03%)	:arrow_down:
...e/dolphinscheduler/server/master/MasterServer.java	0.00% <0.00%> (ø)
...e/dolphinscheduler/server/worker/WorkerServer.java	0.00% <0.00%> (ø)
...r/api/service/impl/ProcessInstanceServiceImpl.java	60.85% <0.00%> (ø)
... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

59.0% Coverage
0.0% Duplication

[lyleshaw]

We need to update corresponding unit tests to get those new checks covered.

Got it.

[zhongjiajie]

@lyleshaw Please add a issue to target this PR, BTW, can we add some separate function from create and update function? I have do the same thing in Tenant and Queue https://github.com/apache/dolphinscheduler/blob/78e912257330c8ec488df7d42e025f47e15331c9/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/QueueServiceImpl.java#L70-L110

[lyleshaw]

Hi all, I have solved the above problems (including adding tests, abstracting to checkParams functions, etc.) Please feel free to re-review it. @zhongjiajie @EricGao888

[zhongjiajie]

Hi all, I have solved the above problems (including adding tests, abstracting to checkParams functions, etc.) Please feel free to re-review it. @zhongjiajie @EricGao888

@lyleshaw But I find out we have some failed CI step, could you please make a check?

[zhongjiajie]

@lyleshaw It seems dwonload jdbc driver error, could you try to rebase on upstream/dev, and force push to restart CI?

[lyleshaw]

@lyleshaw It seems dwonload jdbc driver error, could you try to rebase on upstream/dev, and force push to restart CI?

I usually use git merge instead of git rebase, hoping things won't go wrong...

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

70.7% Coverage
0.0% Duplication

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

[github-actions[bot]]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.