dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Bug] [api&datasource-plugin] When creating a Presto data source, the catalog/database (schema) format is not supported. Tables with the same name under different databases will be displayed on the Create Data Quality Task page

Open hyjunhyj opened this issue 2 years ago • 3 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

What happened

  1. When creating Presto data source, catalog/database (schema) format is not supported in the "Database Name" input box
  2. When filling in the real database name in the "Database Name" input box, and then on the Create Data Quality Task page, there is no data in the source data table selection box
  3. When filling in the real catalog in the "Database name" input box, and then on the Create Data Quality task page, the source data table selection box will display tables with the same name in different databases. After selecting the table with the same name, the columns of the table and the table with the same name will be displayed in the source table column selection box

What you expected to happen

  1. Support catalog/database (schema) when creating presto data source
  2. Avoid situations 2 and 3 in "What happened"

How to reproduce

  1. Case 1 create_presto
  2. Case 2 create_presto3 dq1
  3. Case 3 create_presto2 dq2

Anything else

In my local, in order to solve this problem without affecting other data sources, I made some small changes:

  1. Override the checkDatasourcePatter method of PrestoDataSourceProcessor to allow the catalog/database (schema) format to pass the check
  2. Modify the getTableColumns method in dolphinScheduler-api. To avoid duplicate columns in tables with the same name, pass in the schema parameter when querying

Version

3.0.0-beta-2

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

hyjunhyj avatar Aug 01 '22 11:08 hyjunhyj

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

github-actions[bot] avatar Aug 01 '22 11:08 github-actions[bot]

good job,please paste pictures in English environment next time, thx

davidzollo avatar Aug 08 '22 14:08 davidzollo

good job,please paste pictures in English environment next time, thx

ok, thanks for reminding

hyjunhyj avatar Aug 09 '22 10:08 hyjunhyj

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Oct 19 '23 00:10 github-actions[bot]

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

github-actions[bot] avatar Oct 28 '23 00:10 github-actions[bot]