dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[fix-10961][alert server]Change the content of alert to an array

Open jackfanwan opened this issue 2 years ago • 6 comments

Change the content of alert to an array

close: #10961

jackfanwan avatar Jul 18 '22 10:07 jackfanwan

@kezhenxu94 Hello, can you take a look at it for me?

jackfanwan avatar Jul 19 '22 03:07 jackfanwan

PTAL @kezhenxu94 @caishunfeng

jackfanwan avatar Jul 20 '22 02:07 jackfanwan

Codecov Report

Merging #11033 (7fe8cab) into dev (818648d) will decrease coverage by 0.09%. The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                dev   #11033      +/-   ##
============================================
- Coverage     40.27%   40.18%   -0.10%     
- Complexity     4931     4951      +20     
============================================
  Files           982      988       +6     
  Lines         37568    37721     +153     
  Branches       4127     4147      +20     
============================================
+ Hits          15130    15157      +27     
- Misses        20903    21023     +120     
- Partials       1535     1541       +6     
Impacted Files Coverage Δ
...cheduler/plugin/alert/email/EmailAlertChannel.java 53.33% <66.66%> (+5.71%) :arrow_up:
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) :arrow_down:
...r/plugin/task/sqoop/parameter/SqoopParameters.java 55.12% <0.00%> (-1.29%) :arrow_down:
...nscheduler/service/process/ProcessServiceImpl.java 28.79% <0.00%> (-0.51%) :arrow_down:
...cheduler/plugin/task/api/TaskExecutionContext.java 94.00% <0.00%> (ø)
...eduler/plugin/task/chunjun/ChunJunTaskChannel.java 0.00% <0.00%> (ø)
...heduler/plugin/task/chunjun/ChunJunParameters.java 75.86% <0.00%> (ø)
...phinscheduler/plugin/task/chunjun/ChunJunTask.java 0.00% <0.00%> (ø)
...cheduler/plugin/task/chunjun/ChunJunConstants.java 0.00% <0.00%> (ø)
...ugin/task/chunjun/ChunJunTaskExecutionContext.java 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov-commenter avatar Jul 25 '22 03:07 codecov-commenter

@jackfanwan can you solve the conflicts?

zhongjiajie avatar Jul 28 '22 08:07 zhongjiajie

@jackfanwan can you solve the conflicts?

ok

jackfanwan avatar Jul 28 '22 09:07 jackfanwan

@caishunfeng Please clear the commit log when merging PR, there exist a lot of unused log. image

ruanwenjun avatar Aug 12 '22 02:08 ruanwenjun