dolphinscheduler
dolphinscheduler copied to clipboard
[Fix-10795][plugin] sqoop task query columns bug
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
fix: #10795
Codecov Report
Merging #10776 (45324bc) into dev (35a10d0) will increase coverage by
0.35%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## dev #10776 +/- ##
============================================
+ Coverage 40.64% 40.99% +0.35%
- Complexity 4818 5572 +754
============================================
Files 902 1003 +101
Lines 36195 44594 +8399
Branches 3994 5939 +1945
============================================
+ Hits 14710 18282 +3572
- Misses 20022 24495 +4473
- Partials 1463 1817 +354
Impacted Files | Coverage Δ | |
---|---|---|
...inscheduler/plugin/task/sqoop/SqoopColumnType.java | 0.00% <0.00%> (ø) |
|
.../sqoop/generator/sources/MySQLSourceGenerator.java | 0.00% <0.00%> (ø) |
|
...olphinscheduler/plugin/task/emr/EmrParameters.java | 50.00% <0.00%> (-21.43%) |
:arrow_down: |
...inscheduler/server/worker/config/WorkerConfig.java | 35.48% <0.00%> (-16.90%) |
:arrow_down: |
...org/apache/dolphinscheduler/dao/entity/Tenant.java | 61.76% <0.00%> (-10.97%) |
:arrow_down: |
...inscheduler/server/master/config/MasterConfig.java | 28.00% <0.00%> (-7.00%) |
:arrow_down: |
...olphinscheduler/plugin/task/mlflow/MlflowTask.java | 67.44% <0.00%> (-6.59%) |
:arrow_down: |
.../org/apache/dolphinscheduler/dao/entity/Queue.java | 45.76% <0.00%> (-5.86%) |
:arrow_down: |
...uler/api/controller/WorkFlowLineageController.java | 33.33% <0.00%> (-5.56%) |
:arrow_down: |
.../master/processor/TaskExecuteRunningProcessor.java | 20.00% <0.00%> (-5.00%) |
:arrow_down: |
... and 219 more |
Help us with your feedback. Take ten seconds to tell us how you rate us.
Hi @CallMeKingsley97 , please associate the issue.
@SbloodyS hi, there is no issue for this bug, Do I need to submit an issue?
@SbloodyS hi, there is no issue for this bug, Do I need to submit an issue?
Yes. To target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.
hello, I associated the issue.
hello, I associated the issue.
I'll review this pr later. Thanks.
@CallMeKingsley97 should we also need to make some change of our frontend code?
Yep, when user change the Column Type from Some Columns
to All Columns
, frontend should not transmit the data of Some Columns
to the backend. more infomation you can see the issue https://github.com/apache/dolphinscheduler/issues/10795
@zhongjiajie
please check the fail CI, I found that the checkstyle fail. @CallMeKingsley97
please check the fail CI, I found that the checkstyle fail. @CallMeKingsley97
Is that ok? 😂
@CallMeKingsley97 I found no modification of the front end part, so this is a full pr, can this issue be fixed?
@CallMeKingsley97 I found no modification of the front end part, so this is a full pr, can this issue be fixed?
ok
@CallMeKingsley97 May I ask whether there are any updates for this PR?
@CallMeKingsley97 May I ask whether there are any updates for this PR?
Completed!
LGTM
Can this PR be merged now?🤭
Please run mvn spotless:apply
to fix format error. @CallMeKingsley97
Please run
mvn spotless:apply
to fix format error. @CallMeKingsley97
Done