dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement][Master] Remove the spring annotation in un-spring bean.

Open ruanwenjun opened this issue 2 years ago • 4 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

I find we have use spring annotation in some class which is not a spring bean. https://github.com/apache/dolphinscheduler/blob/423cc5b9be678a3ea30afadad2667bf7d6330324/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/LowerWeightHostManager.java#L47-L75

I hope we can optimize these.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

ruanwenjun avatar Jul 04 '22 03:07 ruanwenjun

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

github-actions[bot] avatar Jul 04 '22 03:07 github-actions[bot]

@ruanwenjun I noticed that after the instantiation of a class, use the AutowireCapableBeanFactory. AutowireBean bean of injection, AutowireCapableBeanFactory is on the basis of the BeanFactory realize the management of the existing examples

image

guodongym avatar Jul 09 '22 15:07 guodongym

@guodongym In my knowledge, directly return is enough, there is no need to set to the beanFactory?

ruanwenjun avatar Jul 10 '22 02:07 ruanwenjun

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Aug 10 '22 00:08 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Dec 01 '23 00:12 github-actions[bot]

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

github-actions[bot] avatar Dec 09 '23 00:12 github-actions[bot]