dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Feature][SQLTask] Suggest SQL task support variables in anywhere

Open zhuxt2015 opened this issue 2 years ago • 3 comments

Purpose of the pull request

fix #10745

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

zhuxt2015 avatar Jul 03 '22 11:07 zhuxt2015

Codecov Report

Merging #10746 (18afe65) into dev (13d400c) will increase coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev   #10746   +/-   ##
=========================================
  Coverage     39.36%   39.36%           
- Complexity     4631     4632    +1     
=========================================
  Files           987      987           
  Lines         37566    37566           
  Branches       4183     4183           
=========================================
+ Hits          14787    14788    +1     
  Misses        21227    21227           
+ Partials       1552     1551    -1     
Impacted Files Coverage Δ
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.77% <0.00%> (+0.69%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 03 '22 12:07 codecov-commenter

Hi @zhuxt2015 please resolve the conflicts.

caishunfeng avatar Aug 11 '22 01:08 caishunfeng

BTW, @zhuxt2015 can you add some UT for it?

caishunfeng avatar Aug 15 '22 07:08 caishunfeng