dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Feature-10683][Task Plugin] Add Java Task Plugin.

Open 106umao opened this issue 3 years ago • 20 comments

This feature close #10683

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

106umao avatar Jun 30 '22 04:06 106umao

Codecov Report

Merging #10689 (6fc1e27) into dev (efedc9a) will decrease coverage by 0.01%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10689      +/-   ##
============================================
- Coverage     38.66%   38.64%   -0.02%     
+ Complexity     4038     4035       -3     
============================================
  Files           992      991       -1     
  Lines         36573    36546      -27     
  Branches       4266     4264       -2     
============================================
- Hits          14141    14124      -17     
+ Misses        20806    20800       -6     
+ Partials       1626     1622       -4     
Impacted Files Coverage Δ
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 43.54% <0.00%> (-6.46%) :arrow_down:
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) :arrow_down:
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-1.39%) :arrow_down:
...nscheduler/plugin/task/api/model/TaskResponse.java

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jun 30 '22 05:06 codecov-commenter

SonarCloud CI failed

pinkhello avatar Jul 13 '22 08:07 pinkhello

OWASP Dependency Check CI Failed

pinkhello avatar Jul 13 '22 08:07 pinkhello

You need to add the JAVA task documentation link in the docsdev.js file.

https://github.com/apache/dolphinscheduler/blob/dev/docs/configs/docsdev.js

thx, have done

106umao avatar Jul 14 '22 14:07 106umao

@Amy0104 Please help code review.

zhuangchong avatar Jul 15 '22 01:07 zhuangchong

@zhongjiajie @SbloodyS @Amy0104 Please help code review. thanks.

zhuangchong avatar Jul 20 '22 01:07 zhuangchong

Hi @zhuangchong @SbloodyS @Amy0104 please help me restart CI failed

106umao avatar Jul 24 '22 08:07 106umao

Hi @zhuangchong @SbloodyS @Amy0104 please help me restart CI failed

Merging the latest dev code can effectively reduce the probability of E2E failure.

SbloodyS avatar Jul 24 '22 08:07 SbloodyS

Hi @zhuangchong @SbloodyS @Amy0104 please help me restart CI failed

Merging the latest dev code can effectively reduce the probability of E2E failure.

Thank you for your guidance. Be sure to do so next time.

106umao avatar Jul 24 '22 12:07 106umao

I add some comments on the English version docs. Thanks.

Thanks,I still need to learn from you

106umao avatar Jul 27 '22 09:07 106umao

I add some comments on the English version docs. Thanks.

Thanks,I still need to learn from you

@106umao You're welcome. We are lucky to have a devoted contributor like you. Thanks again for your effort.

EricGao888 avatar Jul 27 '22 09:07 EricGao888

Backend part overall LGTM, it would be better if we could have those exceptions covered in UTs.

@SbloodyS Could u please take another look when available? Thanks~

EricGao888 avatar Jul 28 '22 03:07 EricGao888

Backend part overall LGTM, it would be better if we could have those exceptions covered in UTs.

@SbloodyS Could u please take another look when available? Thanks~

Will take a look this afternoon.

SbloodyS avatar Jul 28 '22 03:07 SbloodyS

Backend part overall LGTM, it would be better if we could have those exceptions covered in UTs.

thx, have done

106umao avatar Jul 28 '22 08:07 106umao

Hi, @SbloodyS PTAL

106umao avatar Jul 31 '22 15:07 106umao

I've restarted the failed CI.

EricGao888 avatar Aug 03 '22 02:08 EricGao888

@SbloodyS @zhongjiajie @EricGao888 Please help with code review, thanks.

zhuangchong avatar Aug 09 '22 00:08 zhuangchong

LGTM as long as CI passes.

thanks, I have done some work again. PTAL

106umao avatar Aug 11 '22 07:08 106umao

somebody can help me look on the docs dead link error: [✖] https://dolphinscheduler.apache.org/python/index.html → Status: 404

106umao avatar Aug 11 '22 08:08 106umao

somebody can help me look on the docs dead link error: [✖] https://dolphinscheduler.apache.org/python/index.html → Status: 404

Please merge the latest dev branch code.

zhuangchong avatar Aug 12 '22 03:08 zhuangchong

somebody can help me look on the docs dead link error: [heavy_multiplication_x] https://dolphinscheduler.apache.org/python/index.html → Status: 404

Please merge the latest dev branch code.

have done, pls reaview for me

106umao avatar Aug 12 '22 15:08 106umao

Please solve the ci check license error.

zhuangchong avatar Sep 07 '22 21:09 zhuangchong

@106umao Congrats! Thanks for the contributions : )

EricGao888 avatar Sep 09 '22 03:09 EricGao888