dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[improve] [python] variable and packge can not pass to python task type

Open zhongjiajie opened this issue 2 years ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

What happened

When I write a code as below and pass funtion largest_size to Python arg definition, is should work because my code is correctly. But it failed because of python task can not get variable and libariy we already decalere.

from pathlib import Path

download_dir = "/tmp/demo"
store_dir = "dolphinscheduler"

def largest_size():
    result = (None, 0)
    paths = Path(download_dir).joinpath(store_dir).glob("**/*")

    for path in paths:
        # skip is path is directory
        if path.is_dir():
            continue
        file_size = path.stat().st_size
        if result[0] is None or file_size > result[1]:
            result = (path.name, file_size)
    print(result)

to make it work, I have to change to

- from pathlib import Path

- download_dir = "/tmp/demo"
- store_dir = "dolphinscheduler"

def largest_size():
+    from pathlib import Path
+ 
+   download_dir = "/tmp/demo"
+   store_dir = "dolphinscheduler"

    result = (None, 0)
    paths = Path(download_dir).joinpath(store_dir).glob("**/*")

    for path in paths:
        # skip is path is directory
        if path.is_dir():
            continue
        file_size = path.stat().st_size
        if result[0] is None or file_size > result[1]:
            result = (path.name, file_size)
    print(result)

this is not very user firendly

What you expected to happen

ATT

How to reproduce

ATT

Anything else

ATT

Version

dev

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

zhongjiajie avatar Jun 23 '22 06:06 zhongjiajie

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

github-actions[bot] avatar Jun 23 '22 06:06 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Dec 06 '23 00:12 github-actions[bot]

already fix after we add https://github.com/apache/dolphinscheduler-sdk-python/blob/48586a3702df3f708044c8c03eedd442f21cf24f/setup.cfg#L79 to python sdk

zhongjiajie avatar Dec 09 '23 06:12 zhongjiajie