datasketches-cpp icon indicating copy to clipboard operation
datasketches-cpp copied to clipboard

Unnecessary virtual specifier on destructor in final class hll_sketch_alloc

Open devillove084 opened this issue 4 months ago • 0 comments

Description When compiling code that includes and uses the hll_sketch class with the Clang compiler, a -Wunnecessary-virtual-specifier warning is generated. The warning points to the destructor of the hll_sketch_alloc class, which is marked as virtual while the class itself is declared as final.

Virtual method '~hll_sketch_alloc' is inside a 'final' class and can never be overridden [-Wunnecessary-virtual-specifier]

devillove084 avatar Sep 01 '25 08:09 devillove084