datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard
verified publisher icon apache

Avoid clone for LogicalPlan during optimizer passes

Open jayzhan211 opened this issue 1 year ago • 2 comments

Which issue does this PR close?

Closes #9637.

Rationale for this change

What changes are included in this PR?

Boxed plan #9763 is included too.

Are these changes tested?

Are there any user-facing changes?

TODO

  1. benchmark (This PR)
  2. rewrite inputs for other complex plans e.g. DDL, extensions

jayzhan211 avatar Mar 24 '24 09:03 jayzhan211

Hi @jayzhan211 -- I only just now saw this PR. I had some time this morning and didn't see this PR, so I was playing around with a slightly different (and more incremental approach) in https://github.com/apache/arrow-datafusion/pull/9780 -- basically the idea is to support rewriting in place using the TreeNode API

It seems to be promising so far.

It will take a few PRs to get there, but I think it is showing promise.

alamb avatar Mar 24 '24 14:03 alamb

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 24 '24 01:05 github-actions[bot]