datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Replace logical plan from Arc<T> to Box<T>

Open jayzhan211 opened this issue 1 year ago • 3 comments

Which issue does this PR close?

Closes #.

Rationale for this change

#9637 I think it is easier to avoid clone after the plan are all boxed instead of arced

What changes are included in this PR?

  1. Change Arc to Box
  2. union is changed to Vec<T> instead of Vec<Box<T>>

Are these changes tested?

Are there any user-facing changes?

Screenshot 2024-03-24 at 12 05 54 PM

jayzhan211 avatar Mar 24 '24 03:03 jayzhan211

It is part of #9768 , if #9768 is too complex to review, we can merge this first.

jayzhan211 avatar Mar 24 '24 12:03 jayzhan211

Thanks @jayzhan211 -- I only just saw that you were working on this -- I agree this would be a good change. However, I think it will be a substantial performance regression until we also avoid so many logical plan clone's in the optimizer

alamb avatar Mar 24 '24 14:03 alamb

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 24 '24 01:05 github-actions[bot]