datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Move `make_array` to datafusion-functions

Open alamb opened this issue 1 year ago • 3 comments

Is your feature request related to a problem or challenge?

Part of https://github.com/apache/arrow-datafusion/issues/9285 and https://github.com/apache/arrow-datafusion/issues/8045

The goal is to extract function definitions out of the datafusion core.

Note the make_array function is somewhat special in that it has several special cases in datafusion core at the moment. Not only do the special cases make it hard to move, it also means some datafusion functionality is not available to scalar udf functions

I think this ticket will be blocked on removing the special case handling of MakeArrayin the expression rewriter(link) -- I will file a follow on ticket

Describe the solution you'd like

Move the make_array function to datafusion-functions-array

Describe alternatives you've considered

No response

Additional context

Note I have a draft PR with some of this code: https://github.com/apache/arrow-datafusion/pull/9222 but likely won't have time to work on it for a while

alamb avatar Feb 20 '24 08:02 alamb

I think https://github.com/apache/arrow-datafusion/issues/9289 may be able to help us with the simplify example

alamb avatar Feb 20 '24 08:02 alamb

@jayzhan211 I wonder if you have thoughts or time to work on this ticket?

alamb avatar Feb 20 '24 08:02 alamb

not sure how to do yet, but I will take it.

/take

jayzhan211 avatar Feb 20 '24 08:02 jayzhan211