datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

feat: issue #9224 substitute tlide in table path

Open Lordworms opened this issue 1 year ago • 1 comments

Which issue does this PR close?

Closes #9224

Rationale for this change

What changes are included in this PR?

issue #9224 substitute tlide in table path

Are these changes tested?

Are there any user-facing changes?

Lordworms avatar Feb 18 '24 03:02 Lordworms

I correct the issue discription withCloses #9224.

It's a trigger to close this issue after merge this PR.

So I suggest you could fill issue template better instead of just append

jackwener avatar Feb 18 '24 12:02 jackwener

Hmm, looks like one more windows CI failure: https://github.com/apache/arrow-datafusion/actions/runs/8084527721/job/22089988905?pr=9259

You might simply disable the test on windows like

#[not(cfg(target_family = "windows"))]
fn test ...

https://github.com/apache/arrow-datafusion/blob/d6717f8ef062dd9d6ba3e781ad4ebbbd5fbbedc3/datafusion/sqllogictest/bin/sqllogictests.rs#L21

alamb avatar Feb 28 '24 18:02 alamb

Thanks again @Lordworms

alamb avatar Feb 28 '24 22:02 alamb