Minor: reuse the group key row buffer to avoid reallocation

Open yjshen opened this issue 2 years ago • 2 comments

Which issue does this PR close?

Closes #.

Rationale for this change

Find code comments while reading the new aggregation code and tries to fix it here.

What changes are included in this PR?

Use the RowConverter's new append API to reuse rows buffer.

Are these changes tested?

Existing tests.

Are there any user-facing changes?

No.

Aug 26 '23 17:08 yjshen

I guess we can do this once https://github.com/apache/arrow-rs/pull/4742 is released (probably in arrow 47, 🔜 )

Sep 14 '23 18:09 alamb

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

May 02 '24 01:05 github-actions[bot]