datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

ReduceOuterJoin optimizer support `cast or try_cast` expr.

Open liukun4515 opened this issue 3 years ago • 2 comments

Is your feature request related to a problem or challenge? Please describe what you are trying to do. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] (This section helps Arrow developers understand the context and why for this feature, in addition to the what)

In the join test reduce_left_join_1

let sql = "select * from t1 left join t2 on t1.t1_id = t2.t2_id where t2.t2_id < 100";

the below sql will be convert to the inner join. But after the https://github.com/apache/arrow-datafusion/pull/3396 and move the type coercion in the beginning of the optimizer, we will do the cast first for the t2.t2_id < 100, and get the cast(t2.t2_id as int64) < Int64(100).

If with the cast or try_cast, the ReduceOuterJoin will not work.

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

liukun4515 avatar Sep 21 '22 08:09 liukun4515

I'll try to handle this case.

HuSen8891 avatar Sep 22 '22 03:09 HuSen8891

I'll try to handle this case. Thanks @AssHero I find a way to bypass it first.

liukun4515 avatar Sep 22 '22 06:09 liukun4515

@AssHero Do you have plan to do this recently?

liukun4515 avatar Sep 28 '22 06:09 liukun4515