datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Migrate the `cross join -> inner join optimization` from the planner to the optimizer

Open xudong963 opened this issue 2 years ago • 1 comments

Is your feature request related to a problem or challenge? Please describe what you are trying to do. Migrate the cross join -> inner join optimization from the planner to the optimizer, and make it as an optimization rule.

Related code: https://github.com/apache/arrow-datafusion/blob/master/datafusion/sql/src/planner.rs#L770

Additional context cross join -> inner join optimization: https://github.com/apache/arrow-datafusion/pull/1566

xudong963 avatar Jul 09 '22 10:07 xudong963

hi, @xudong963 I'm interested in trying this, may I try this?

Veeupup avatar Jul 23 '22 09:07 Veeupup

@Veeupup Hey, how is it coming along? @xudong963 could I also try to fix this issue?

sadilet avatar Aug 26 '22 17:08 sadilet

sorry, I have been busy with some other stuff these times and forgot it... @sadilet feel free to take it!

Veeupup avatar Aug 27 '22 01:08 Veeupup

@sadilet Thanks!

xudong963 avatar Aug 27 '22 03:08 xudong963

@sadilet Hi, https://github.com/apache/arrow-datafusion/pull/3482 there is a related PR.

xudong963 avatar Sep 15 '22 12:09 xudong963