datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

InList: add more integration test for Inlist

Open liukun4515 opened this issue 3 years ago • 0 comments

Thank you @liukun4515 -- I reviewed the tests carefully and I think this looks good.

The code "feels" a little more complicated than needed but I think it is doing what it needs to and the test coverage is good.

I wonder if it is worth just 1 test in sql_integration somewhere that ensures this implementation is hooked up correctly rather than just relying on tests in in_list.rs

I think it would be good if @Ted-Jiang was also able to review this PR prior to merging it, but it isn't necessary.

Originally posted by @alamb in https://github.com/apache/arrow-datafusion/pull/2809#pullrequestreview-1026740587

liukun4515 avatar Jul 03 '22 03:07 liukun4515