datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard
verified publisher icon apache

fix: Added nullable return from date_add(#19151)

Open manishkr opened this issue 1 month ago • 5 comments

Which issue does this PR close?

  • Closes #19151.

Rationale for this change

  • This will make return type of data_add udf nullable.

What changes are included in this PR?

Are these changes tested?

  • Yes

Are there any user-facing changes?

  • No

manishkr avatar Dec 09 '25 08:12 manishkr

https://github.com/apache/datafusion/pull/19225 is very similar to this PR. Please check it for additional inspiration.

martin-g avatar Dec 09 '25 12:12 martin-g

#19225 is very similar to this PR. Please check it for additional inspiration. Added scalar case. Thanks

manishkr avatar Dec 09 '25 12:12 manishkr

@martin-g If it doesn't need any further improvement, please approve. Thanks

manishkr avatar Dec 11 '25 05:12 manishkr

@manishkr Please fix the PR title: s/data_add/date_add/

martin-g avatar Dec 11 '25 06:12 martin-g

@manishkr Please fix the PR title: s/data_add/date_add/

Done, Thanks.

manishkr avatar Dec 11 '25 08:12 manishkr

@comphead Could you help in merging this. Thanks.

manishkr avatar Dec 17 '25 11:12 manishkr