apache
Allow base64 encoding of fixedsizebinary arrays
Which issue does this PR close?
- Closes #18949
Rationale for this change
We need to be able to base64 encode fixedsizebinary types.
Are these changes tested?
Yes
Are there any user-facing changes?
No
Thank you @maxburke for the PR! Thank you @martin-g for the SLT test. I have moved it over and verified coverage using tarpaulin. Here is a PR to move the unit tests over:
https://github.com/urbanlogiq/arrow-datafusion/pull/92
@maxburke I think this PR looks good. Would you mind merging in my branch so move the testing over to SLT? Then I think we can merge here.
@maxburke I think this PR looks good. Would you mind merging in my branch so move the testing over to SLT? Then I think we can merge here.
Done!
@maxburke Do you mind resolving that last comment on removing the unit test now that we have SLT? I don't think your PRs are configured to allow maintainers to commit to them. Or if you think we still need it in, lmk. Then I'll hit the merge button.
In order to work down the outstanding PR queue I will merge this one one and make a follow on PR to remove the unit test.
Thank you @maxburke @timsaucer @Jefffrey @martin-g and @comphead !
