apache
[datafusion-spark] Implement `factorical` function
Which issue does this PR close?
- Closes #16124 .
Rationale for this change
What changes are included in this PR?
Implement spark-compatible factorical function
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
@tlm365 - I wonder if you would be willing to help pick this PR back up now that we have merged a PR with a bunch of tests from @shehabgamin here:
- https://github.com/apache/datafusion/pull/16409
We are hoping to generate some example PRs to use when starting to fill out the rest of the functions and I was thinking this one might be a good one
@tlm365 - I wonder if you would be willing to help pick this PR back up now that we have merged a PR with a bunch of tests from @shehabgamin here:
* [chore: generate basic spark function tests #16409](https://github.com/apache/datafusion/pull/16409)
@alamb Sure! I'd be happy to help pick this PR back. Thanks for pointing me to the recent test additions — that will definitely help.
Thank you @tlm365 -- this looks great to me
What do you think @shehabgamin -- anything else that this PR should have (I am hoping to use it as an example when porting other functions)
@alamb @tlm365 I will review this in the next couple of hours!
