datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Optimize Hex Function

Open ajita-asthana opened this issue 7 months ago • 2 comments

Which issue does this PR close?

  • Closes #15986

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

ajita-asthana avatar May 17 '25 21:05 ajita-asthana

You should document why using the view struct is optimal on this PR or the linked issue. If no tests are being added, you document why no additional tests are needed. Seems like this is referencing the Java implementation but it's not clear whether that is beneficial.

jfahne avatar May 19 '25 03:05 jfahne

Marking as draft as I think this PR is no longer waiting on feedback and I am trying to make it easier to find PRs in need of review. Please mark it as ready for review when it is ready for another look

alamb avatar Jun 13 '25 17:06 alamb

Would it be feasible to add a benchmark for the new spark compatible hex function as well if it doesn't exist ?

ajita-asthana avatar Jul 13 '25 11:07 ajita-asthana

Closing this as stale; feel free to reopen it when it becomes active again

Jefffrey avatar Nov 17 '25 13:11 Jefffrey