datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

IsDistinctFrom/IsNotDistinctFrom for decimal type

Open liukun4515 opened this issue 3 years ago • 1 comments

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

part of #122 in the #122, we have supported the decimal type in datafusion, but for IsDistinctFrom、IsNotDistinctFrom we just convert the value to FLOAT64.

we should follow the mathematics operation for decimal type pull request https://github.com/apache/arrow-datafusion/pull/1483 and refactor these two operations.

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

liukun4515 avatar Jan 17 '22 04:01 liukun4515

@liukun4515 this can be closed, right? proper comparison of decimal128 seems to be implemented and it's not converting to float64.

https://github.com/apache/arrow-rs/blob/master/arrow/src/util/decimal.rs#L163

kmitchener avatar Sep 22 '22 16:09 kmitchener