datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Improve `AggregateFuzz` testing: generate random queries

Open alamb opened this issue 1 year ago • 2 comments

Which issue does this PR close?

Part of https://github.com/apache/datafusion/issues/12114

Rationale for this change

Now that we have a great aggregation fuzz testing framework from @Rachelint , lets use it to increase coverage

Specifically while thinking about how to improve test coverage I think the key constraints are what types are supported by what aggregate functions. Thus it makes sense to have different functions tested in different combinations

What changes are included in this PR?

  1. Add a query generator to randomly create queries
  2. Update aggregate fuzz testing to cover various permutations of types and aggregates
  3. List other potential things to test

Are these changes tested?

Only tests

Are there any user-facing changes?

No, only tests

alamb avatar Oct 10 '24 11:10 alamb

FYI @Rachelint

alamb avatar Oct 15 '24 19:10 alamb

The query generator seems really excellent!

Rachelint avatar Oct 16 '24 16:10 Rachelint

Thank you @goldmedal

alamb avatar Oct 21 '24 20:10 alamb

Thanks @alamb and @Rachelint for reviewing!

goldmedal avatar Oct 22 '24 09:10 goldmedal