datafusion
datafusion copied to clipboard
Verify if DISTINCT supports all types, incl binary, complex, etc
Wondering if DISTINCT supports all types, incl binary, complex, etc? if its not we should be mentioning it in the doc, and double check it returns a respective error instead of crash/corruption
Originally posted by @comphead in https://github.com/apache/datafusion/pull/11012#discussion_r1649198256
take
Questions:
- By
complextype, you mean like:List,Map,Struct,...? - Do we need to verify if the results are correct, or that we can run DISTINCT on all the data types?
Thanks @LorrensP-2158466
I think we need to write tests for possible combinations and if there is a crash replace it with not_impl_err!, if the result is incorrect we can open an issue and reference this issue next to the failing test
Ah Okey, I was going in the correct direction, thanks!