datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Expand Test Coverage for ScalarUDF's

Open berkaysynnada opened this issue 1 year ago • 0 comments

Is your feature request related to a problem or challenge?

After merging PR #10504, a new file monotonicity.rs was introduced. This file contains rules for determining whether the output of functions created with the make_math_unary_udf and make_math_binary_udf macros preserves the order of the input. Currently, these rules are not covered by tests.

Describe the solution you'd like

We need to expand the test coverage to ensure that the order-preserving properties of these functions are correctly implemented and protected. We can add both unit and .slt tests.

Describe alternatives you've considered

No response

Additional context

An example test exists in order.slt

https://github.com/apache/datafusion/blob/f80794779ef251528ee983e22ec03c158deb42a6/datafusion/sqllogictest/test_files/order.slt#L1077-L1108

berkaysynnada avatar May 21 '24 12:05 berkaysynnada