datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Port aggregate test to sqllogictest

Open jayzhan211 opened this issue 1 year ago • 0 comments

Is your feature request related to a problem or challenge?

There are many rust test that exists in aggregate functions. Moving them to sqllogictest is easier to maintain and avoid additional testing functions like generic_test_op, assert_string_aggregate, assert_aggregate, assert_error_bounds, and so on. It also makes #8708 a lot easier.

#10382 is an example of how tests are moved to.

I think most of them are Good first issue:

  • [ ] Sum #10382
  • [ ] Count #10383
  • [ ] average #10401
  • [ ] min_max
  • [ ] array_agg
  • [ ] bit_and_or_xor
  • [ ] correlation

Describe the solution you'd like

Port rust test in datafusion/physical-expr/src/aggregate/tdigest.rs to datafusion/sqllogictest/test_files/aggregate.slt

We can just add the test to aggregate.slt even if there is a duplicated test case to make the review easier.

Describe alternatives you've considered

No response

Additional context

No response

jayzhan211 avatar May 05 '24 14:05 jayzhan211