datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Published 20 hours ago • verified publisher icon apache

Remove ScalarFunctionDefinition

Open lewiszlw opened this issue 9 months ago • 5 comments

Which issue does this PR close?

Closes https://github.com/apache/datafusion/issues/10175.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

lewiszlw avatar May 01 '24 03:05 lewiszlw

🚀

alamb avatar May 02 '24 11:05 alamb

It might be nice to wait to merge this PR until we make the #10217 release, to minimize API churn as 38.0.0 already removes BuiltInScalarFunction

alamb avatar May 02 '24 12:05 alamb

Clippy failed on other code. I run clippy locally and more than one warning needed to be addressed, might be done in another pr.

lewiszlw avatar May 02 '24 14:05 lewiszlw

Clippy failed on other code. I run clippy locally and more than one warning needed to be addressed, might be done in another pr.

I think it may be due to the new rust https://releases.rs/docs/1.78.0/

will file a ticket

update: filed https://github.com/apache/datafusion/issues/10352

alamb avatar May 02 '24 15:05 alamb

I merged up from main to pick up the fix for https://github.com/apache/datafusion/issues/10352

alamb avatar May 02 '24 20:05 alamb

Now that https://github.com/apache/datafusion/pull/10407 is merged, I believe main is open for 38.0.0 business !

🚀 -- tanks again @lewiszlw

alamb avatar May 07 '24 16:05 alamb