datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard
verified publisher icon apache

DataFusion weekly project plan (Andrew Lamb) - April 29, 2024

Open alamb opened this issue 1 year ago • 3 comments

Follow on to https://github.com/apache/datafusion/issues/10172

It would be great for other contributors to DataFusion who plan non trivial work could try to make them visible somehow as well 🙏 (feel free to copy / modify the format)

My Highlights from Last Week

  • We have a new website https://datafusion.apache.org/ (with redirects from old urls) 🎉
  • We have worked through https://github.com/apache/arrow-datafusion/issues/9691 -- thanks to @phillipleblanc, @comphead, @andygrove and @tisonkun and @lewiszlw)
  • We merged quite a few PRs for https://github.com/apache/datafusion/issues/9637 (e.g. 10184 and 10212. etc. Thanks to @peter-toth, @LordWorms, @kevinmingtarja)
  • @jayzhan and @liukun cleaned up how zero argument handling works https://github.com/apache/datafusion/pull/10193
  • @Jefffrey Added MEDIAN(DISTINCT ..) support: The last aggregate without distinct support
  • @simonvandel made date_bin (2x faster) (https://github.com/apache/datafusion/pull/10215) 🚀

My (personal) goals

1000 projects are built using DataFusion 📈

My (personal) plans for this week

  • [ ] Support https://github.com/apache/arrow-datafusion/issues/9691 (complete https://github.com/apache/datafusion/issues/10135)
  • [ ] Keep removing copies to make planning faster: https://github.com/apache/arrow-datafusion/issues/9637
  • [ ] (Stretch goal) Document ParquetExec more (so it is clear / easier to understand what is already supported and what else could be useful https://github.com/apache/arrow-datafusion/issues/9929)

Project Queue (list of future projects)

  • [ ] https://github.com/apache/arrow-datafusion/issues/9929 (likely not this week)

Projects I plan to help actively help review / plan

  • [ ] https://github.com/apache/arrow-rs/issues/5374 (I am struggling to find time, but we are making progress, slowly)
  • [ ] https://github.com/apache/datafusion/issues/10313
  • [ ] https://github.com/apache/arrow-datafusion/issues/9494
  • [ ] https://github.com/apache/arrow-datafusion/issues/9493 with @wiedld

Algorithm for (my) prioritizing PR reviews

Note there are many committers who can and do review and merge PRs, so this is not the priorities of the project as a whole, just the approximate algorithm I use to prioritize my own time.

Priority:

  1. Bug fixes (where something is just incorrect), especially regressions (where it used to work and now does not)
  2. Improvements directly related to features needed for InfluxDB (my employer)
  3. Documentation and test improvements (I view these as very strategically important)
  4. PRs that I think are strategically important
  5. Other new features / additions to functionality (note this is the lowest)

The top strategically important projects in my head are:

Thus, if you are interested in contributing to DataFusion and are interested in a fast turn around time I would recommend looking into bug fixes / test improvements / documentation or the projects named above.

If you propose adding new functionality, especially if the PR is large/complex and not connected to a wider need, the review cycle will likely be longer. You can make it a shorter cycle by looking at the comments on other recent PRs and following the same model (e.g. ensure there are tests in sqllogictest for example, the CI passes, includes documentation, etc)

Background

The idea of this ticket is make my plans for DataFusion visible, largely for my own personal organizational needs, but also to:

  1. Communicate / coordinate in the community
  2. Help provide an interesting summary of what is happening in DataFusion this week

alamb avatar Apr 29 '24 11:04 alamb

Review Queue

  • [x] https://github.com/apache/datafusion/pull/10268
  • [x] https://github.com/apache/datafusion/pull/10221
  • [x] https://github.com/apache/datafusion/pull/9593
  • [x] https://github.com/apache/datafusion/pull/10234

SQL Parser:

  • [x] https://github.com/sqlparser-rs/sqlparser-rs/pull/1215

alamb avatar Apr 29 '24 11:04 alamb

Inspired by https://github.com/apache/datafusion/pull/9593 from @suremarc , and https://github.com/apache/datafusion/issues/10257 from @nga, I started organizing sort based optimizations in a new epic: https://github.com/apache/datafusion/issues/10313

alamb avatar May 01 '24 09:05 alamb

Review Queue

  • [x] https://github.com/apache/datafusion/pull/10358#pullrequestreview-2037025870
  • [ ] https://github.com/apache/datafusion/pull/10354
  • [ ] https://github.com/apache/datafusion/pull/10149
  • [ ] https://github.com/apache/datafusion/pull/10208

Arrow

  • [x] https://github.com/apache/arrow-rs/pull/5705#pullrequestreview-2036752575
  • [ ] https://github.com/apache/arrow-rs/pull/5703
  • [ ] https://github.com/apache/arrow-rs/pull/5704
  • [ ] https://github.com/apache/arrow-rs/pull/5707

alamb avatar May 02 '24 19:05 alamb

Should be @jayzhan211 and @liukun4515 . Not me ;p

liukun avatar May 04 '24 02:05 liukun

Sorry @liukun -- my bad

alamb avatar May 04 '24 11:05 alamb

Next week: https://github.com/apache/datafusion/issues/10395

alamb avatar May 06 '24 16:05 alamb