datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Avoid comparison coercion logic `comparison_binary_numeric_coercion` in non-comparison coercion logic `coerced_from`

Open jayzhan211 opened this issue 1 year ago • 0 comments

Is your feature request related to a problem or challenge?

I think the logic between these two logic is easily misuse, before someone come out a nice way to handle coercion logic in one. I think we should keep them separate and refrain from mixing their use https://github.com/apache/datafusion/pull/10221#issuecomment-2077669921

Describe the solution you'd like

Remove comparison_binary_numeric_coercion from coerced_from but avoid breaking existing logic. https://github.com/apache/datafusion/blob/bab39f78cd7a4aca92c60950812016b4f72798b1/datafusion/expr/src/type_coercion/functions.rs#L456-L464

Describe alternatives you've considered

No response

Additional context

No response

jayzhan211 avatar Apr 26 '24 02:04 jayzhan211